Code review comment for lp://staging/~henninge/launchpad/bug-434055-combined

Revision history for this message
Henning Eggers (henninge) wrote :

= Summary =

Bug 434055 and bug 434195.
Convert 'hasspefications-specs.pt' to 3.0 design. Convert specificationstarget-assignments to UI 3.0.

This is a combined branch, jtv's part for bug 434195 has already been reviewed.

== Implementation details ==

The trouble with hasspecificaitons-spece.pt was that it is used in many different contexts and that each hat its own ApplicationMenu. The menus shared most links in varying combinations, so I aggregated the links into one Mixin that is now used in all Menus.

I converted the ApplicationMenus to NavigationMenus to use them as global-actions. This was the most straight-forward way of conversion without loosing any functionality. I also changed that for specificationstarget-assignments where jtv had removed the menu completely.

I fixed the Breadcrumb for the specifications vhost as it was repeating the context name (like "Foo Bar >> Specifications involving Foo Bar", now it's "Foo Bar >> Blueprints") and I normalized on using the term "blueprint" ;-)

Some label and page_title work was also done.

Did I forget to mention anything?

== Code ==

I will paste a separate diff to show the differences to jtv's branch.

« Back to merge proposal