Code review comment for lp://staging/~henninge/launchpad/bug-427956

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Looks good. Not entirely happy about having menu-pages.txt in our tree
since it tests navigation menus using our pages as examples, not our
pages in the context of navigation menus, but I don't see an easy
solution that would solve everything there.

The new page title for POFiles is ugly, and lists neither the language
nor the product. I'm surprised the new breadcrumbs don't solve that.
But given that we're making those a separate effort, it shouldn't hold
up this branch.

Also thanks for making the translation view the default page for the
POFile. That's something we've been wanting for some time now.

Jeroen

review: Approve

« Back to merge proposal