Code review comment for lp://staging/~henninge/launchpad/bug-427956

Revision history for this message
Henning Eggers (henninge) wrote :

= Overview =

Mechanical conversion of POFile:+translate page to 3.0.

Along with that I also changed:
- DefaultView for POFile to +translate which reflects the current practice.
- POFile:+index renamed to +details, because it is not the index any more.
- Renamed menu entries to be usable for in-page links.

The changes drew in a host of page test failures that had to be addressed so the diff has grown bigger than expected. I moved menu-pages.txt into translations because we are the only ones using it.

= Test command =

bin/test -vv -t breadcrumbs -t menu-pages.txt -t xx-licensing.txt -t xx-pofile-details.txt -t xx-pofile-translate-alternative-language.txt -t xx-pofile-translate-message-filtering.txt -t xx-rosetta-pofile-export.txt -t pofile.txt -t translationgroups

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/translations/configure.zcml
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/pofile.py
  lib/lp/translations/browser/tests/menu-pages.txt
  lib/lp/translations/browser/tests/test_breadcrumbs.py
  lib/lp/translations/stories/navigation-links/pofile.txt
  lib/lp/translations/stories/standalone/xx-licensing.txt
  lib/lp/translations/stories/standalone/xx-pofile-details.txt
  lib/lp/translations/stories/standalone/xx-pofile-translate-alternative-language.txt
  lib/lp/translations/stories/standalone/xx-pofile-translate-message-filtering.txt
  lib/lp/translations/stories/standalone/xx-rosetta-pofile-export.txt
  lib/lp/translations/stories/translationgroups/45-test-distro-restricted-permissions.txt
  lib/lp/translations/templates/pofile-translate.pt

« Back to merge proposal