Code review comment for lp://staging/~hazmat/txzookeeper/backoff-retry-managed-sanity

Reviewers: mp+146938_code.launchpad.net,

Message:
Please take a look.

Description:
Session management and retry improvements.

Lots of improvements and several bug fixes.

Previously managed clientwas returning the underlying session client
instead
of retry, so retry wasn't enabled for uses trying to catch/store the
client from
connect.

The retry code was using seconds for session timeout instead of
milliseconds.

The retry code wasn't taking account of the start of retry properly when

determining max retry.

The retry on persistent error wasn't signaling to the managed client to
establish a new session.

The client code wasn't properly cleaning up txzk handles on conn
timeouts.

The session establishment now uses the client session events so even
without
activity or active watches the session is restablished.

Session restablishment will now backoff on reconnects for up to 6m.

https://code.launchpad.net/~hazmat/txzookeeper/backoff-retry-managed-sanity/+merge/146938

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7307051/

Affected files:
   A .bzrignore
   A [revision details]
   M debian/changelog
   M setup.py
   M txzookeeper/__init__.py
   M txzookeeper/client.py
   M txzookeeper/lock.py
   A txzookeeper/managed.py
   M txzookeeper/node.py
   M txzookeeper/queue.py
   A txzookeeper/retry.py
   M txzookeeper/tests/__init__.py
   M txzookeeper/tests/common.py
   A txzookeeper/tests/proxy.py
   M txzookeeper/tests/test_client.py
   A txzookeeper/tests/test_conn_failure.py
   M txzookeeper/tests/test_lock.py
   A txzookeeper/tests/test_managed.py
   M txzookeeper/tests/test_node.py
   M txzookeeper/tests/test_queue.py
   A txzookeeper/tests/test_retry.py
   M txzookeeper/tests/test_security.py
   M txzookeeper/tests/test_session.py
   M txzookeeper/tests/test_utils.py
   M txzookeeper/tests/utils.py
   M txzookeeper/todo.txt
   M txzookeeper/utils.py