thanks for the review
https://codereview.appspot.com/6935068/diff/12001/juju/rapi/context.py File juju/rapi/context.py (right):
https://codereview.appspot.com/6935068/diff/12001/juju/rapi/context.py#newcode85 juju/rapi/context.py:85: if not self.authenticated and not func.__name__ == "_login": On 2013/01/18 14:04:23, bcsaller wrote: > func.__name__ has a bad smell to it but fair enough
its already playing with func.. not many other options outside of decorating every other function with another attribute for perm, which still amounts to the same, ie func inspection.
https://codereview.appspot.com/6935068/diff/12001/juju/rapi/transport/ws.py File juju/rapi/transport/ws.py (right):
https://codereview.appspot.com/6935068/diff/12001/juju/rapi/transport/ws.py#newcode68 juju/rapi/transport/ws.py:68: On 2013/01/18 14:04:23, bcsaller wrote: > Is there an use case for a logout/inverse to this stopping the delta? I suspect > not at this time.
logout not possible with the underlying zk auth mechanism, wrt to use not at the moment outside of disconnect.
ideally stream sub/unsub would be explicit api methods, but doing so without gui support first would break the gui.
https://codereview.appspot.com/6935068/
« Back to merge proposal
thanks for the review
https:/ /codereview. appspot. com/6935068/ diff/12001/ juju/rapi/ context. py context. py (right):
File juju/rapi/
https:/ /codereview. appspot. com/6935068/ diff/12001/ juju/rapi/ context. py#newcode85 context. py:85: if not self.authenticated and not func.__name__
juju/rapi/
== "_login":
On 2013/01/18 14:04:23, bcsaller wrote:
> func.__name__ has a bad smell to it but fair enough
its already playing with func.. not many other options outside of
decorating every other function with another attribute for perm, which
still amounts to the same, ie func inspection.
https:/ /codereview. appspot. com/6935068/ diff/12001/ juju/rapi/ transport/ ws.py transport/ ws.py (right):
File juju/rapi/
https:/ /codereview. appspot. com/6935068/ diff/12001/ juju/rapi/ transport/ ws.py#newcode68 transport/ ws.py:68:
juju/rapi/
On 2013/01/18 14:04:23, bcsaller wrote:
> Is there an use case for a logout/inverse to this stopping the delta?
I suspect
> not at this time.
logout not possible with the underlying zk auth mechanism, wrt to use
not at the moment outside of disconnect.
ideally stream sub/unsub would be explicit api methods, but doing so
without gui support first would break the gui.
https:/ /codereview. appspot. com/6935068/