Code review comment for lp://staging/~hatch/juju-gui/detail-hang

Revision history for this message
Jeff Pihach (hatch) wrote :

Reviewers: mp+160228_code.launchpad.net,

Message:
Please take a look.

Description:
Fix GUI hanging when service viewed is deleted

WIP BRANCH
The UI will now display a notification if the user is:
1) Viewing a service and it gets destroyed. The user will
   be redirected to the env view.
2) Viewing a unit and it gets destroyed. The user will be
   redirected to the service view.
3) Viewing a unit and its service gets destroyed. The
   user will be redirected to the env view.

The service views have been converted to use promises to
pull the service data in.

To Do:
The unit views still need to be converted to use promises.

Tests need to be written.

This branch cannot land until the multiple 'login' event
bug has been fixed as it causes the application to break
if the user navigates to a service view before the second
'login' event has been dispatched.

https://code.launchpad.net/~hatch/juju-gui/detail-hang/+merge/160228

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8782046/

Affected files:
   A [revision details]
   M app/app.js
   M app/assets/javascripts/ns-routing-app-extension.js
   M app/views/service.js
   M app/views/topology/service.js
   M app/views/unit.js
   M app/views/utils.js
   M test/test_application_notifications.js
   M test/test_service_view.js
   M undocumented

« Back to merge proposal