Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~hatch/charms/trusty/juju-gui/add-uuid-configjs

  1. Trusty Tahr (14.04)
  2. add-uuid-configjs
  3. Merge into trunk
Revision history for this message
Francesco Banconi (frankban) wrote :

This branch looks good Jeff, thank you!
I have some minor comments, and I'd add a test for write_gui_config in test_utils.py:TestStartImprovAgentGui,
similar to test_write_gui_config_with_version_from_jujud, but exercising the juju_env_uuid value.

QA ok.

review: Approve

« Back to merge proposal