We have several hundred lines of them at the top of the file already, it
seemed the wrong time to add to that.
https://codereview.appspot.com/7301061/diff/1/testservices/novaservice/service_http.go#newcode889
testservices/novaservice/service_http.go:889: // TODO: this logic is
actually wrong, not what nova does at all
The wrong is that is should really do the equality check for all five
parts, which is then a ten-comparison if statement. Moving to a more
realistic validation step would be nice but is not actually required for
juju tests.
I'll either land this then some cleanup of the error handling or roll
this branch into that.
https:/ /codereview. appspot. com/7301061/ diff/1/ testservices/ novaservice/ service_ http.go novaservice/ service_ http.go (right):
File testservices/
https:/ /codereview. appspot. com/7301061/ diff/1/ testservices/ novaservice/ service_ http.go# newcode886 novaservice/ service_ http.go: 886: return err // TODO: should
testservices/
be a 4XX error with details
On 2013/02/08 00:02:16, dimitern wrote:
> Why not define an errorResponse for that?
We have several hundred lines of them at the top of the file already, it
seemed the wrong time to add to that.
https:/ /codereview. appspot. com/7301061/ diff/1/ testservices/ novaservice/ service_ http.go# newcode889 novaservice/ service_ http.go: 889: // TODO: this logic is
testservices/
actually wrong, not what nova does at all
The wrong is that is should really do the equality check for all five
parts, which is then a ten-comparison if statement. Moving to a more
realistic validation step would be nice but is not actually required for
juju tests.
https:/ /codereview. appspot. com/7301061/