Code review comment for lp://staging/~gz/bzr/ignore_sigquit_in_ssh_child_162502

Revision history for this message
Martin Packman (gz) wrote :

> Looks good, needs news.

Done.

> signal.SIGQUIT doesn't exist on Windows so you need a getattr()

It can't be seen from the diff in this merge proposal, but the change is already on a nix-only path, after all no fork, no preexec_fn on Windows.

« Back to merge proposal