NRPE Charm

Merge ~guoqiao/charm-nrpe:add-update-status-hook into charm-nrpe:master

  1. Git
  2. lp:~guoqiao/charm-nrpe
  3. add-update-status-hook
  4. Merge into master
Proposed by Joe Guo
Status: Merged
Approved by: Xav Paice
Approved revision: 5342ff7d72b24d8eb79e4febce1f8f9685345fc9
Merged at revision: dcdef1bd268cba8a2efb3fdf50ef4e41b03320e8
Proposed branch: ~guoqiao/charm-nrpe:add-update-status-hook
Merge into: charm-nrpe:master
Diff against target: 71 lines (+39/-11)
2 files modified
hooks/services.py (+16/-11)
hooks/update-status (+23/-0)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
🤖 prod-jenkaas-bootstack continuous-integration Needs Fixing
Linda Guo (community) Approve
BootStack Reviewers Pending
Review via email: mp+409732@code.staging.launchpad.net

Commit message

Add missing update-status hook

Currently in nrpe charm, the update-status hook is missing. We keep seeing this message in juju log:

unit-nrpe-0: 20:47:06 INFO juju.worker.uniter.operation skipped "update-status" hook (missing)

This patch added a separate python script for this hook, to check nagios-nrpe-server status and use status-set hook tool to update status.
The status message is kept identical to before.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:224ab9bec9f325003fbe3c388c93ee41ddf5651f
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/31/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/146/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/553/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/31//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
James Troup (elmo) wrote :

Setting back to work in progress per discussion on the call this evening

Revision history for this message
Joe Guo (guoqiao) wrote :

I have re-written the update-status hook as a python script.
The status message is kept identical as before.
Review appreciated.

Revision history for this message
Linda Guo (lihuiguo) wrote :

lgtm

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:5342ff7d72b24d8eb79e4febce1f8f9685345fc9
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/32/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/153/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/562/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/32//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:5342ff7d72b24d8eb79e4febce1f8f9685345fc9
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/33/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/156/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/572/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-nrpe-ci/33//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Xav Paice (xavpaice) wrote :

CI failure:

2021-10-10 21:46:43 [INFO] Deploying bundle '/home/ubuntu/charm/tests/functional/tests/bundles/xenial.yaml' on to 'zaza-63a7e29f046f' model

FAIL: test_04_check_nagios_ip_is_allowed (tests.nrpe_tests.TestNrpe)

Same test passed on all other bundles.

I think we should raise a separate bug for the failing test, and not block this change on that.

Change LGTM

review: Needs Fixing
Revision history for this message
Xav Paice (xavpaice) wrote :

Misclicked, change LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dcdef1bd268cba8a2efb3fdf50ef4e41b03320e8

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: