Code review comment for lp://staging/~gero-bare/midori/midori-bug-1259705

Revision history for this message
Danielle Foré (danrabbit) wrote :

* for the cookies extension, I don't think list-add/remove are appropriate for expanding items. It's pretty misleading, imo. In fact, I would use "list-remove-symbolic" and "list-remove-all-symbolic" for the delete icons. There aren't really icons for expanding/contracting all items. But I guess "view-sort-ascending" and "view-sort-descending" would make the most sense since we aren't trying to redesign components in this branch.

* Anything opposite "list-add" should be "list-remove" and not "edit-delete". This happens quite a lot in the side panel and extensions preferences.

* I don't think "edit-clear-all" is a thing. At least GNOME and elementary have only "edit-clear".

* "help-browser" should be "help-contents" for the same reason as above.

* Typo in diffline 1547 "go-uo" should be "go-up"

review: Needs Fixing

« Back to merge proposal