QtMir

Merge lp://staging/~gerboland/qtmir/ual-catch-exception into lp://staging/qtmir

  1. ual-catch-exception
  2. Merge into trunk
Proposed by Gerry Boland
Status: Merged
Approved by: Michael Terry
Approved revision: 483
Merged at revision: 490
Proposed branch: lp://staging/~gerboland/qtmir/ual-catch-exception
Merge into: lp://staging/qtmir
Diff against target: 19 lines (+8/-1)
1 file modified
src/modules/Unity/Application/upstart/taskcontroller.cpp (+8/-1)
To merge this branch: bzr merge lp://staging/~gerboland/qtmir/ual-catch-exception
Reviewer Review Type Date Requested Status
Daniel d'Andrada (community) Needs Information
Michael Terry (community) Approve
Unity8 CI Bot (community) continuous-integration Approve
Review via email: mp+293805@code.staging.launchpad.net

Commit message

UAL can throw on creating Application if invalid appId, catch instead of aborting

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

To test, just run:
ubuntu-app-launch ubuntu-ui-toolkit-gallery
and ensure unity8 doesn't crash!

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:483
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/201/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1511
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1475
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/1475
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1475/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1475/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1475/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1475/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1475/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1475
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/1475/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/201/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

LGTM

review: Approve
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

"""
qCDebug(QTMIR_APPLICATIONS) << "ApplicationController::createApp - UAL failed to create app for appId"
"""

Shouldn't it be a qCWarning instead?

review: Needs Information

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches