QtMir

Merge lp://staging/~gerboland/qtmir/small-hooks-change into lp://staging/qtmir

  1. small-hooks-change
  2. Merge into trunk
Proposed by Gerry Boland
Status: Needs review
Proposed branch: lp://staging/~gerboland/qtmir/small-hooks-change
Merge into: lp://staging/qtmir
Diff against target: 83 lines (+3/-19)
3 files modified
src/platforms/mirserver/mirserverhooks.cpp (+3/-15)
src/platforms/mirserver/mirserverhooks.h (+0/-3)
src/platforms/mirserver/qmirserver_p.cpp (+0/-1)
To merge this branch: bzr merge lp://staging/~gerboland/qtmir/small-hooks-change
Reviewer Review Type Date Requested Status
Unity8 CI Bot (community) continuous-integration Approve
Mir development team Pending
Review via email: mp+321743@code.staging.launchpad.net

Commit message

Do not claim ownership of InputDeviceHub, just get it long enough to register observer.

This makes MirServerHooks slightly more self-contained

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:638
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/661/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4844
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4872
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4683/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4683/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4683/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4683/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4683/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4683
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4683/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/661/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

638. By Gerry Boland

Clean up diff

637. By Gerry Boland

No need for Hooks to export the Input Device Hub

636. By Gerry Boland

Have MirServerHooks be more self-contained

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches