Code review comment for lp://staging/~gepatino/ubuntu-accomplishments-web/icons_urls

Revision history for this message
Gabriel PatiƱo (gepatino) wrote :

I've been fixing some stuff Janos pointed to me by mail:

1. Now the rendered html is the same as the one generated by using the trunk.
2. I wasn't handle multicategories for opportunities and trhopies. It's now fixed
3. I'd removed accidentaly the labels Today and This Week in the Latest trophies page, fixed.

I had to clean up some code and then I realized we had code duplication when creating the data structure sent to the template.

I've created a format_queryset method to avoid duplication, and redefine it only when needed.

review: Needs Resubmitting

« Back to merge proposal