Code review comment for lp://staging/~gcollura/content-hub/fix-1384490

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Sorry! We've decided to take another approach to fixing this bug, since it isn't really possible for us to mimic the application's colours correctly without the developer having to explicitly set headerColor/backgroundColor/footerColor properties on the peer picker and then us copying gradient stops from the UITK (which could then easily get out of sync if this is changed in the UITK), we've decided to have the peer picker keep the same light appearance across all applications and just force the font colour to be correct. I'll see about preparing a branch with the new approach this week, since it might require a bit of fiddly work for the 1.0 implementation (since only UITK 1.1 allows explicitly setting the header colour).

« Back to merge proposal