Thanks for the review!
> I'll have a bit of look into this and get back to you on what I > find.
Ok, thanks a lot :)
> Aside from that it looks like you've got a couple of typos for Qt.rgba listed > as Qt.rbga (g and b switched around),
Ops, sorry for the typo. (fixed it)
> so dark layouts still get the white > background.
The alpha layer is set to 0.1, so it's just a bit lighter, but still a dark grey (at least in my tests)
> However, with these corrected the apps box for light backgrounds > becomes gray, so we might need to think about that a bit more.
I thought it would have been better to remove that background color of the Rectangle and leave everything of the same color, tell me what you think :)
Thanks again for the review
Giulio
« Back to merge proposal
Thanks for the review!
> I'll have a bit of look into this and get back to you on what I
> find.
Ok, thanks a lot :)
> Aside from that it looks like you've got a couple of typos for Qt.rgba listed
> as Qt.rbga (g and b switched around),
Ops, sorry for the typo. (fixed it)
> so dark layouts still get the white
> background.
The alpha layer is set to 0.1, so it's just a bit lighter, but still a dark grey (at least in my tests)
> However, with these corrected the apps box for light backgrounds
> becomes gray, so we might need to think about that a bit more.
I thought it would have been better to remove that background color of the Rectangle and leave everything of the same color, tell me what you think :)
Thanks again for the review
Giulio