Bazaar

Code review comment for lp://staging/~garyvdm/bzr/unicode_bom_detect

  1. unicode_bom_detect
  2. Merge into bzr.dev
Revision history for this message
Martin Packman (gz) wrote :

Is this partly inspired by the current thread on python-dev?
<http://mail.python.org/pipermail/python-dev/2010-January/094828.html>

Can you clearly document what the actual heuristic is? It's not clear to me from reading the diff, and it's not the same as the notepad one. Why, for instance, are you not decoding UTF-8 text?

What happens if a UnicodeDecodeError is raised from one of these functions?

review: Needs Information
Reply

« Back to merge proposal