Code review comment for lp://staging/~gary/zc.recipe.testrunner/support-system-python

On Jul 13, 2009, at 5:33 PM, Francis J. Lacoste wrote:

> Review: Approve
> On July 13, 2009, Gary Poster wrote:
>> Gary Poster has proposed merging
>> lp:~gary/zc.recipe.testrunner/support-system-python into
>> lp:~gary/zc.recipe.testrunner/trunk.
>>
>> Requested reviews:
>> Francis J. Lacoste (flacoste)
>>
>> Support the new zc.buildout 1.4.0+ include-site-packages option.
>
> Apart this question:
>
>> === modified file 'buildout.cfg'
>> --- buildout.cfg 2007-01-24 15:58:29 +0000
>> +++ buildout.cfg 2009-07-09 18:52:45 +0000
>> @@ -1,6 +1,8 @@
>> [buildout]
>> parts = test
>> develop = .
>> + zc.buildout
>> + zc.buildout/zc.recipe.egg_
>
> Is this a change you want to commit? Is it usual to use zc.buildout
> as a
> develop egg?
>
> It looks good.

No, sorry I should have called that out. This is what I do during
development. Once there are releases for these dependencies, I'll
take out this clause before I merge. The same goes with zc.recipe.egg
and z3c.recipe.filetemplate.

Thanks

Gary