Code review comment for lp://staging/~gary/zc.recipe.testrunner/support-system-python

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On July 13, 2009, Gary Poster wrote:
> Gary Poster has proposed merging
> lp:~gary/zc.recipe.testrunner/support-system-python into
> lp:~gary/zc.recipe.testrunner/trunk.
>
> Requested reviews:
> Francis J. Lacoste (flacoste)
>
> Support the new zc.buildout 1.4.0+ include-site-packages option.

Apart this question:

> === modified file 'buildout.cfg'
> --- buildout.cfg 2007-01-24 15:58:29 +0000
> +++ buildout.cfg 2009-07-09 18:52:45 +0000
> @@ -1,6 +1,8 @@
> [buildout]
> parts = test
> develop = .
> + zc.buildout
> + zc.buildout/zc.recipe.egg_

Is this a change you want to commit? Is it usual to use zc.buildout as a
develop egg?

It looks good.

  review approve

--
Francis J. Lacoste
<email address hidden>

review: Approve

« Back to merge proposal