Code review comment for lp://staging/~gary/lazr.restful/fix-webservice-testing-infrastructure

Revision history for this message
Leonard Richardson (leonardr) wrote :

> Fixes testing infrastructure and packaging problems.

I have two comments.

1. Why the heck is 'roman' a dependency of lazr.restful? It's not in the code and it's such a random thing to need.

2. This comment isn't terribly helpful.

70 + # We want the initial slash of the path, so we subtract 1 from
71 + # the base_url's len.

I'd prefer something like:

# We want just one character of the base_url (the slash that begins the path), so we cut
# off the length of the base_url minus one character.

review: Needs Information

« Back to merge proposal