Code review comment for lp://staging/~gary/lazr.enum/devel

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Hi Gary,

This is good. I have a couple of small fixes:

- You have a bunch of files missing a newline at the end:

  src/lazr/enum/configure.zcml
  src/lazr/enum/interfaces.py
  src/lazr/enum/tests/test_proxy.py

- There is a comment that needs fixing in

> 656 +# The enumerated_type_registry is a mapping of all enumerated types to the
> 657 +# actual class. There should only ever be one EnumeratedType or
> 658 +# DBEnumerateType with a particular name. This serves two purposes:
> 659 +# * a way to get any enumerated type by its name (used in tales.py)
> 660 +# * a way to iterate over the DBEnumeratedTypes in order to confirm the
> 661 +# values actually stored in the database.
> 662 +enumerated_type_registry = {}

The reference to tales.py isn't pertinennt anymore.

You probably want to keep a __version__ in __init__.py ?

Thanks

review: Approve

« Back to merge proposal