Code review comment for lp://staging/~gary/launchpadlib/buildout

On March 19, 2009, Gary Poster wrote:
> Gary Poster has proposed merging lp:~gary/launchpadlib/buildout into
> lp:launchpadlib.
>
> Requested reviews:
> LAZR Developers (lazr-developers)
> Francis J. Lacoste (flacoste)
> launchpadlib developers (launchpadlib-developers)
>
> This makes launchpadlib built with buildout.
>
> There are no tests or documents in the package, so this package looks more
> bare than usual.
>
> This requires lazr.uri and the wadllib package that I also have up for
> review. See https://dev.launchpad.net/Hacking. Build lazr.uri and wadllib
> by checking them out, ``cd``'ing into the directory, running ``python
> bootstrap.py``, running ``./bin/buildout``, and running ``./bin/buildout
> setup . sdist``. Then put the .tgz file in the download-cache/dist
> directory.
>

Hi Gary,

Again, make sure that all 'or later' clause are removed. I have a few other
small comments. But this is ready to move to PyPI!

  status approved
  review approve

> === modified file 'TODO.txt'
> --- TODO.txt 2008-08-01 16:46:08 +0000
> +++ TODO.txt 2009-03-16 21:02:52 +0000
> @@ -4,5 +4,4 @@
> - make == and is work
> - integrate httplib2 caching; conditional get; conditional patch

That last one has been done.

> - Flesh out HTTPErrors as per Francis email
> -- Move launchpadlib._utils.uri into a separate cheeseshop package
> - Support hosted file resources

So has that one.

Actually, I think we should simply get rid of that file. We have a bug tracker
for these things.

> --- src/launchpadlib/NEWS.txt 1970-01-01 00:00:00 +0000
> +++ src/launchpadlib/NEWS.txt 2009-03-16 21:02:52 +0000
> @@ -0,0 +1,8 @@
> +=====================
> +NEWS for launchpadlib
> +=====================
> +
> +1.0 (200X-XX-XX)
> +================
> +
> +- Initial release

Should be updated with 'First PyPI release.'

--
Francis J. Lacoste
<email address hidden>