Code review comment for lp://staging/~gary/launchpad/zbuildout

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On August 21, 2009, Gary Poster wrote:
> > Why not use sys.stdout.flush() here instead of using a newline?
>
> Because this feeds into the same new code in the parent process that
> now has the readline behavior. I don't think a flush is going to help
> if the listener is doing a readline. Maybe I could change the
> listener behavior for this case so that it no longer does a readline,
> and then I could do a flush here, but just sending a newline seemed
> like a nice one-line fix with no downside that I saw.

That's fine.

--
Francis J. Lacoste
<email address hidden>

« Back to merge proposal