Code review comment for lp://staging/~gary/launchpad/utf8-list-team-members

Revision history for this message
Gary Poster (gary) wrote :

This cherrypick candidate came about because Tom informed me that a script (https://pastebin.canonical.com/25425/) which was calling list-team-members was generating this error:

Traceback (most recent call last):
 File "./list-team-members", line 60, in <module>
   script.run()
 File "/srv/launchpad.net/production/launchpad-rev-8745/lib/lp/services/scripts/base.py", line 248, in run
   self.main()
 File "./list-team-members", line 55, in main
   print "\n".join(sorted(list(set(member_details))))
UnicodeEncodeError: 'ascii' codec can't encode characters in position 14282-14288: ordinal not in range(128)

This indicates that some of those details are unicode, and Python is trying to encode them in ascii, and failing. The changes in this branch addressed the problem by encoding the values in UTF8, and Tom indicated that this change would not be a problem.

« Back to merge proposal