Launchpad itself

Code review comment for lp://staging/~gary/launchpad/sqlprofiler

  1. sqlprofiler
  2. Merge into devel
Revision history for this message
Benji York (benji) wrote :

This branch looks good. Here are a couple of little things:

I would add MemoryError to the (SystemExit, KeyboardInterrupt)
exceptions. Since that tuple is repeated several times you might want
to define a "constant" for it as well.

I don't understand the comment near the end of the diff: "This should
never happen."

review: Approve (code)

« Back to merge proposal