Code review comment for lp://staging/~gary/launchpad/sqlprofiler

Hi Gary,

This branch looks fine, though this:

674 +def _get_frame(f):
675 + "if the frame is None, make one."
676 + if f is None:
677 + try:
678 + raise ZeroDivisionError
679 + except ZeroDivisionError:
680 + f = sys.exc_info()[2].tb_frame.f_back.f_back
681 + return f

Gave me pause. It looks a bit hackish; I'm assuming that there's a reason to do it this way?

Anyways, r=me on the assumption that you know something that I don't (the likelihood of which tends towards 1).