Code review comment for lp://staging/~gary/launchpad/profiler
Revision history for this message
| Gary Poster (gary) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
On Aug 16, 2011, at 8:31 AM, Robert Collins wrote:
> On Wed, Aug 17, 2011 at 12:19 AM, Gary Poster <email address hidden> wrote:
>>
>> On Aug 11, 2011, at 11:02 PM, Robert Collins wrote:
...
>>> Could we not just fix bzr to do what you need, given the closeness of the projects?
>>
>> It would be possible. I don't see an advantage at all until we are happy with the profiler work; and even then, upstream inclusion, no matter how friendly, takes time and involves a different perspective.
>>
>> If for some reason you want to use the exact lock from the bzr profiler, that would be easy enough to maintain, as I did in a previous branch. However, it is simpler to understand the code if we define the lock locally, as I did here.
>
> Well, its a little sad to have two different implementations floating
> around, is all.
True. It would be fun to contribute to bzr. Maybe I'll get around to it. I'd want to try to change things around a bit if it were going upstream: reuse often leads me to different designs than refactoring.