Code review comment for lp://staging/~gary/launchpad/poppyasync

Revision history for this message
Gary Poster (gary) wrote :

This fixes the (unintentionally) incomplete migration of getting rid of the zope branch.

- We no longer need to get docutils from the zope branch: we get it from a standard distribution via buildout.

- We no longer need ThreadedAsync at all. It is no longer used by Zope, and poppy can do just fine with asyncall.

- The sourcecode Makefile needed to have zope cleaned out. It also needed to have storm and bzr cleaned out from other buildout-releated changes.

- lib/canonical/poppy/server.py had some lint errors. I didn't investigate the bare excepts (lines 65, 133, and 142 of the file), but fixed the rest.

Thanks

Gary

« Back to merge proposal