Merge lp://staging/~gary/launchpad/move-events-to-filters into lp://staging/launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Gary Poster |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10164 |
Proposed branch: | lp://staging/~gary/launchpad/move-events-to-filters |
Merge into: | lp://staging/launchpad/db-devel |
Diff against target: |
1278 lines (+376/-298) 23 files modified
database/sampledata/current-dev.sql (+4/-4) database/sampledata/current.sql (+4/-4) database/schema/comments.sql (+1/-1) database/schema/patch-2208-37-0.sql (+12/-0) lib/canonical/launchpad/mail/helpers.py (+1/-5) lib/lp/bugs/browser/bugsubscriptionfilter.py (+45/-1) lib/lp/bugs/browser/structuralsubscription.py (+4/-35) lib/lp/bugs/browser/tests/test_bugsubscriptionfilter.py (+85/-0) lib/lp/bugs/browser/tests/test_structuralsubscription.py (+0/-133) lib/lp/bugs/doc/bug-change.txt (+7/-2) lib/lp/bugs/doc/bugnotification-sending.txt (+133/-10) lib/lp/bugs/doc/bugsubscription.txt (+15/-8) lib/lp/bugs/doc/structural-subscriptions.txt (+0/-2) lib/lp/bugs/interfaces/bugsubscriptionfilter.py (+8/-0) lib/lp/bugs/interfaces/structuralsubscription.py (+6/-26) lib/lp/bugs/model/bugsubscriptionfilter.py (+6/-0) lib/lp/bugs/model/structuralsubscription.py (+16/-35) lib/lp/bugs/model/tests/test_bugsubscriptionfilter.py (+9/-0) lib/lp/bugs/model/tests/test_bugtask.py (+3/-2) lib/lp/bugs/tests/structural-subscription-target.txt (+10/-19) lib/lp/bugs/tests/test_bugchanges.py (+4/-1) lib/lp/bugs/tests/test_structuralsubscriptiontarget.py (+3/-6) lib/lp/registry/doc/private-team-roles.txt (+0/-4) |
To merge this branch: | bzr merge lp://staging/~gary/launchpad/move-events-to-filters |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | code | Approve | |
Graham Binns (community) | code | Approve | |
Stuart Bishop (community) | db | Approve | |
Robert Collins | db | Pending | |
Review via email:
|
Commit message
[r=allenap,
Description of the change
Part of https:/
This branch moves the event filter enumeration off of the structural subscription, and on to the filter object. Combined with Gavin's filter work, this makes it possible to, for instance, subscribe to all bug notifications for a project or package with a "ui" tag and also subscribe to only creation/closing bug notifications with a "bugjam" tag.
"make lint" only complains about some circular dependencies that are not an issue with my changes to my knowledge.
All tests I touched pass for me. ec2 is currently running tests for this branch.
This branch is large but I'm not sure how I would have made it smaller. If you'd like to talk it over with me maybe we could come up with a way to divide it?
Thank you
Gary
A worry: target. addSubscription did result in a subscription that had a level of NOTHING. We never exposed that, to my knowledge, instead relying publicly on addBugSubscription, which always explicitly set a level of COMMENTS. Now, this branch creates subscriptions without filters, which means addBugSubscription has the same result, but addSubscription does not. I don't think it is an issue, but I'd like a sanity check from an expert (gmb? :-D )