Code review comment for lp://staging/~gary/launchpad/honor_revisions

  review approve
  status approved

Hi Gary,

This is excellent. My only comment on the code is that you three instances of
if not tip and revision:

Not a big deal, but raises my three strikes and refactor alarm. Maybe you
could modify get_revision_id to return revision and revision_name and use that
throughout?

Anyway, take it or leave it.

On November 24, 2009, Gary Poster wrote:
> This branch changes the sourcecode update script to honor revision
> numbers. It also adds revision numbers to sourcedeps.conf. This change
> is important to allow us to move production-devel to buildbot.
>

I'd like to point out that this will also allow us to get rid of running the
whole Launchpad test suite on all of the branches still managed by PQM (apart
ShipIt and c-i-p) We can only run their test suite and then land the branch
updating the revision spec in the Launchpad tree using the regular mechanism.

--
Francis J. Lacoste
<email address hidden>