Code review comment for lp://staging/~gary/launchpad/bug777874

Revision history for this message
Robert Collins (lifeless) wrote :

Two comments:
 - changing the user affects union to an or may throw out bug search
query plans; you'll need to test this with an eye towards timeouts.
[OTOH it may have been written that way in the first place and never
altered; I suspect its deliberately a union [but I haven't annotated
to be sure]].

 - in the client side js, the limit of checking whether the task was
new seems unnecessary - isn't it reasonable to just cross check
regardless?

« Back to merge proposal