Code review comment for lp://staging/~gary/launchpad/bug723999

Revision history for this message
j.c.sackett (jcsackett) wrote :

Re: the three vs four, I'm fine leaving it as is, I was just confused. A quick comment wouldn't suck, but I'm not a stickler.

Re: breaking the huge function into little bits. I think you're probably right about it not being doable. I might agree with you on the ORM vs raw SQL design patterns, but let's take that discussion out of this medium and to irc or email.

For everything else, thanks for agreeing to the changes and thanks for this impressive branch.

review: Approve

« Back to merge proposal