Code review comment for lp://staging/~gary/launchpad/bug553368

Revision history for this message
Gary Poster (gary) wrote :

lint:

./lib/canonical/launchpad/webapp/login.py
     490: E302 expected 2 blank lines, found 1

This is for a function that has a comment in front of it; that apparently confuses our linter.

./lib/canonical/launchpad/webapp/tests/test_login.py
     626: E301 expected 1 blank line, found 0
     627: E301 expected 1 blank line, found 0

This is for the inline class, which I need because I have to subclass the dynamically generated class. I could do "type" games instead if you wanted, but I thought an inline class was simpler and easier to understand.

« Back to merge proposal