Merge lp://staging/~gary/launchpad/bug548-db-3 into lp://staging/launchpad/db-devel
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 10177 |
Proposed branch: | lp://staging/~gary/launchpad/bug548-db-3 |
Merge into: | lp://staging/launchpad/db-devel |
Prerequisite: | lp://staging/~wgrant/launchpad/bug548-db-2-tests |
Diff against target: |
1057 lines (+693/-128) 5 files modified
lib/canonical/widgets/__init__.py (+12/-0) lib/contrib/oauth.py (+529/-0) lib/lp/bugs/doc/bugnotification-sending.txt (+91/-118) lib/lp/registry/model/person.py (+55/-8) lib/lp/scripts/garbo.py (+6/-2) |
To merge this branch: | bzr merge lp://staging/~gary/launchpad/bug548-db-3 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email:
|
Commit message
[r=bac]
Description of the change
This branch fixes the remaining test failures from wgrant's branch (fixing most of the failures) of my previous branches. It also reinstates the use of a test helper for one file (bugnotificatio
This branch had to fix three sorts of test failures. First, I had hoped that we would be able to make the person-specific settings simply not implemented for teams. This proved to be untenable: at least two automated interface-based functions (verifyObject from zope.interface and lazr.lifecycle's snapshot functionality) crashed and burned by this behavior. Therefore, I opted to make the attributes readonly for teams, using the defaults from the interfaces. I had a mid-implementation call with Danilo about how to tackle that. I want to do what you see here, rather than a __getattr_
- This way keeps you from having to repeat yourself (again) by explicitly listing the attribute names.
- We expect to add many more attributes to this settings bag, and setting up each one manually in a readonly version would be a drag.
- We expect to add a team-based settings bag, and repeating things there would be even more of a drag.
Danilo thought that my preferred approach was acceptable, so I proceeded.
The second test failure was in garbo, cleaning up people. This was simply addressed by teaching it about the new person settings table (that it is safe to ignore it when trying to determine whether a person is still linked).
The last test failure was that ImmutableVisibi
My goal is to get this landed asap to try and make it into PQM. I'd prefer having to make "I'll fix that next" promises if possible, rather than significantly holding up the branch, but I will understand if you are not comfortable with that.
Thank you
Gary
Lines 1 - 396 have been reviewed before, though comments/ requests/ suggestions are welcome.