Code review comment for lp://staging/~gary/launchpad/breadcrumbs

Revision history for this message
Gary Poster (gary) wrote :

This branch addresses bug 434746. The breadcrumbs should no longer duplicate information for the virtual hosts, as described in that bug.

It normalizes the name of these adapters to [name of section]VHostBreadcrumbs, per the Translations pattern.

It removes the @property for text, replacing it with a simple attribute (also affecting Translations).

This does not change Blueprints because Henning did this in another branch (https://code.edge.launchpad.net/~henninge/launchpad/bug-434055-combined/+merge/12229).

This fixes all tests that match the search [bB]read[cC]rumb. There may be more that ec2test reveals.

Thank you

Gary

« Back to merge proposal