Code review comment for lp://staging/~gary/juju-gui/syncMenu

Revision history for this message
Gary Poster (gary) wrote :

Comments

https://codereview.appspot.com/13583044/diff/1/app/index.html
File app/index.html (left):

https://codereview.appspot.com/13583044/diff/1/app/index.html#oldcode44
app/index.html:44: <link rel="stylesheet"
href="/juju-ui/assets/juju-gui.css?reload=temporary">
Flyby. We shouldn't need these any more, now that we've had the new
charm deployed for such a long time.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (left):

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#oldcode114
app/views/topology/service.js:114: d.model.set('placeFromGhostPosition',
false);
Moved below.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#oldcode1338
app/views/topology/service.js:1338: toggleServiceMenu: function(box) {
We don't use this any more.

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13583044/diff/1/app/views/topology/service.js#newcode463
app/views/topology/service.js:463: this.set('currentServiceClickAction',
'showServiceMenu');
Every time you click on a service, you will get the inspector and the
service menu.

https://codereview.appspot.com/13583044/

« Back to merge proposal