Merge lp://staging/~gary/juju-gui/support-no-cookies into lp://staging/juju-gui/experimental
Proposed by
Gary Poster
| Status: | Merged |
|---|---|
| Merged at revision: | 894 |
| Proposed branch: | lp://staging/~gary/juju-gui/support-no-cookies |
| Merge into: | lp://staging/juju-gui/experimental |
| Diff against target: |
168 lines (+115/-4) 2 files modified
app/store/env/base.js (+52/-3) test/test_env.js (+63/-1) |
| To merge this branch: | bzr merge lp://staging/~gary/juju-gui/support-no-cookies |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Juju GUI Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Fix FF problem when cookies are disabled
When cookies are disabled in FF, sessionStorage is disabled. When sessionStorage is disabled, it just crashes with a security exception. This works around the issue.
To post a comment you must log in.
Revision history for this message
| Gary Poster (gary) wrote | # |
Revision history for this message
| Madison Scott-Clary (makyo) wrote | # |
Revision history for this message
| Benjamin Saller (bcsaller) wrote | # |
Revision history for this message
| Gary Poster (gary) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Reviewers: mp+177002_
Message:
Please take a look.
Description:
Fix FF problem when cookies are disabled
When cookies are disabled in FF, sessionStorage is disabled. When
sessionStorage is disabled, it just crashes with a security exception.
This works around the issue.
https:/
(do not edit description out of merge proposal)
Please review this at https:/
Affected files:
A [revision details]
M app/store/
M test/test_env.js