lp://staging/~gary/juju-gui/support-no-cookies

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/juju-gui/experimental at revision 894

Juju GUI Hackers: Pending requested 2013-07-25

Diff: 168 lines (+115/-4)

2 files modified

app/store/env/base.js (+52/-3)
test/test_env.js (+63/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

895. By Gary Poster on 2013-07-25

fix lint

894. By Gary Poster on 2013-07-25

gui crashes/hangs if Firefox has cookies or local storage disabled. this is workaround.

893. By Gary Poster on 2013-07-25

Fix subordinate behavior in Juju Core

The biggest change here is that we update service data with the charm subordinate flag, because juju core does not include that information in the service. This includes a test.

Other changes here are fly-by.
- The yui3-skin-sam class on the body was causing issues by adding styles unnecessarily. I put it on the subapp-browser, where it is sufficient.
- The sandbox sends is_subordinate, not subordinate, for charms. I'm not sure if that is correct, but for now I changed charm.js to handle it. I'd welcome opinions on pushing this back down into the pyjuju sandbox, where I could test it. I'm kind of inclined to do that, actually, but I want to get this branch proposed.
- I made a few changes to the inspector code to handle subordinates a bit better, particularly in the ghost inspector. the ghost inspector has no tests at all, and we have a card for adding them, so I did not try to tack that effort on to this branch.
- I made a small tweak to charm-panel.js so that new services start looking like subordinates immediately.
- I added a small hack that came in handy to track down behavior in a handlebars template. Just add {{debugger}} in the template and you will have a breakpoint there. handy. hopefully not too dangerous! We definitely don't want to check in a template that uses this, and the linter won't check our template code...

R=benji
CC=
https://codereview.appspot.com/11804043

892. By j.c.sackett on 2013-07-25

Updates charm view to use Charm model.

To make it easier to clean up and phase out the old API, the charm views (which
have previously worked on parsed JSON) are updated to use the Charm model and
the old API. This makes it much easier to translate to the new API, and further
down the road, the BrowserCharm model.
-Charm view uses Charm model and loadByPath
-CharmCollection view, which appears to be unused now that the old search is
gone, is deleted.

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/11831043

891. By Jeff Pihach on 2013-07-24

Fixed inspector unit list sorting bug

In order to fix the sorting bug with our current D3 version
we need to render all unit lists at once and then hide/show
when units are in those lists.

This also includes a driveby fix for https image and having
the unit lists closed by default

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/11351046

890. By Richard Harding on 2013-07-24

Support autocomplete of charms in search.

- Adds support to the charm-search widget to autocomplete as a user types
- Adds a new api endpoint to the store 'autocomplete'
- Adds the yui3-skin-sam to enable proper styling of the AC widget. This
caused some CSS changes to undo the damage in other locations.
- Update the view to only deal with the search widget when a store is present.
In tests it's not, and there's no point getting errors around it.
- Make sure we don't display metadata in the tiny charm-token sized used for
the AC results display.
- Update tests to deal with the new search widget updates.
- Add test to the new handlebars unless_eq helper.

Testing Notes:

I know the tests around the AC widget in the search tests are a bit weak. It's
difficult to test since there's not a good way to wait for the html render to
complete with suggestions without doing timeout related code. I've tried to
test that the custom parts of the code we init are touched and working. So we
verify that our results include a charm-token html result vs a plain 'name' of
a charm. Most of the work in there is using code that's already under test,
like firing viewNavigate and such. If we find bugs I'm more than happy to
break into more complicated testing to make sure they don't reoccur, but it's
much of this is tying together code that's already under test.

R=curtis, jeff.pihach
CC=
https://codereview.appspot.com/11126043

889. By Madison Scott-Clary on 2013-07-24

Local charms in the inspector

This branch hides information unavailable from local charms in the charm left-hand panel in the inspector.

R=rharding, benjamin.saller
CC=
https://codereview.appspot.com/11351045

888. By j.c.sackett on 2013-07-24

Sets up sharing links to use jujucharms.com

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/11696045

887. By Gary Poster on 2013-07-24

Subordinates should not be deployed with unit ct.

Deploying a subordinate with a unit count causes an error in core. This
prevents one from entering a unit count in the charm panel (did not touch ghost
inspector, that may also need it) and defaults to 0. This also affects
fakebackend.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/11627044

886. By Richard Harding on 2013-07-24

TRIVIAL: Add raring to the filters.

- There are 6 raring packages undiscoverable currently due to there not being
a filter option to show them
- This adds that string.
- None of these are 'reviewed' so you must uncheck reviewed charms to see
them.
- This will go away when filters do, but was added as a quick favor to
~charmers so the raring ones are 'visible'.

R=
CC=
https://codereview.appspot.com/11507045