LGTM Thanks for doing this :-) one trivial and one question.
https://codereview.appspot.com/7703047/diff/1/app/app.js File app/app.js (right):
https://codereview.appspot.com/7703047/diff/1/app/app.js#newcode276 app/app.js:276: socket_protocol = this.get('socket_protocol'); Should these not be camelCased?
https://codereview.appspot.com/7703047/diff/1/app/app.js#newcode281 app/app.js:281: socket_protocol = socket_protocol || 'ws'; I wonder if we shouldn't default this to 'wss' instead of 'ws' thoughts?
https://codereview.appspot.com/7703047/
« Back to merge proposal
LGTM Thanks for doing this :-) one trivial and one question.
https:/ /codereview. appspot. com/7703047/ diff/1/ app/app. js
File app/app.js (right):
https:/ /codereview. appspot. com/7703047/ diff/1/ app/app. js#newcode276 'socket_ protocol' );
app/app.js:276: socket_protocol = this.get(
Should these not be camelCased?
https:/ /codereview. appspot. com/7703047/ diff/1/ app/app. js#newcode281
app/app.js:281: socket_protocol = socket_protocol || 'ws';
I wonder if we shouldn't default this to 'wss' instead of 'ws' thoughts?
https:/ /codereview. appspot. com/7703047/