Code review comment for lp://staging/~gary/juju-gui/socket_url_revisited

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM -- one tiny change.

https://codereview.appspot.com/7703047/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7703047/diff/1/app/app.js#newcode276
app/app.js:276: socket_protocol = this.get('socket_protocol');
Don't we prefer 'one var per declaration'?

https://codereview.appspot.com/7703047/diff/1/test/test_app.js
File test/test_app.js (right):

https://codereview.appspot.com/7703047/diff/1/test/test_app.js#newcode472
test/test_app.js:472: });
These tests are clean and thorough. Thanks.

https://codereview.appspot.com/7703047/

« Back to merge proposal