LGTM -- one tiny change.
https://codereview.appspot.com/7703047/diff/1/app/app.js File app/app.js (right):
https://codereview.appspot.com/7703047/diff/1/app/app.js#newcode276 app/app.js:276: socket_protocol = this.get('socket_protocol'); Don't we prefer 'one var per declaration'?
https://codereview.appspot.com/7703047/diff/1/test/test_app.js File test/test_app.js (right):
https://codereview.appspot.com/7703047/diff/1/test/test_app.js#newcode472 test/test_app.js:472: }); These tests are clean and thorough. Thanks.
https://codereview.appspot.com/7703047/
« Back to merge proposal
LGTM -- one tiny change.
https:/ /codereview. appspot. com/7703047/ diff/1/ app/app. js
File app/app.js (right):
https:/ /codereview. appspot. com/7703047/ diff/1/ app/app. js#newcode276 'socket_ protocol' );
app/app.js:276: socket_protocol = this.get(
Don't we prefer 'one var per declaration'?
https:/ /codereview. appspot. com/7703047/ diff/1/ test/test_ app.js
File test/test_app.js (right):
https:/ /codereview. appspot. com/7703047/ diff/1/ test/test_ app.js# newcode472 app.js: 472: });
test/test_
These tests are clean and thorough. Thanks.
https:/ /codereview. appspot. com/7703047/