Code review comment for lp://staging/~gary/juju-gui/socket_url_revisited

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+153202_code.launchpad.net,

Message:
Please take a look.

Description:
Prefer socket_port and socket_protocol

In order to allow the charm to be backwards compatible, change the
websocket url code to prefer socket_port and/or socket_protocol if they
are also provided with socket_url in the configuration. Added tests.
Moved pertinent code from index.html to app because it was easier to
test there.

https://code.launchpad.net/~gary/juju-gui/socket_url_revisited/+merge/153202

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7703047/

Affected files:
   A [revision details]
   M app/app.js
   M app/config-debug.js
   M app/config-prod.js
   M app/index.html
   M test/test_app.js

« Back to merge proposal