Code review comment for lp://staging/~gary/juju-gui/sandboxEnv-4

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+154827_code.launchpad.net,

Message:
Please take a look.

Description:
Connect sandbox environment to app

I apologize for this branch's size. On one of my commits I decided to
change the docstring approach for my two files into the YUI approach,
because I liked it so much better. I didn't realize how big the changes
were.

Beyond that, a few other fly-by spelling corrections, some changes I
needed for the tests to pass, and so on, this branch is about finally
connecting the in-browser sandbox environment work with the app. I
added the delta stream and made it possible to use the sandbox
environment by using configuration value.

To QA, in config-debug.js add a "sandbox: true" flag, start up make
devel, and deploy some things. You can't do anything other than deploy
at the moment. :-)

https://code.launchpad.net/~gary/juju-gui/sandboxEnv-4/+merge/154827

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/7896045/

Affected files:
   A [revision details]
   M app/app.js
   M app/index.html
   M app/models/models.js
   M app/store/env/fakebackend.js
   M app/store/env/sandbox.js
   M app/views/charm-panel.js
   M test/test_app.js
   M test/test_fakebackend.js
   M test/test_sandbox.js
   M test/utils.js

« Back to merge proposal