Code review comment for lp://staging/~gary/juju-gui/sandboxEnv-2

Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Complete deploy functionality and tests.

This combines three discrete improvements, each with their own commit.

revno: 423
   add machines for units

revno: 424
   add support for passing a YAML string for service configuration, as
would be passed by file parsing

revno: 425
   add a nextChanges function and tests for it in isolation and with
deploy and addUnit.

Note that rev 424 uses js-yaml 2.0.3, which seems to be a lot better
than previous incarnations in my small tests. I decided it was worth
including. As I said in the .min.js file, I committed this to the tree
rather than using npm because the file we needed was not in npm.

rev 425, with the nextChanges, is the most "sketchy." We'll have to see
how that fares when we actually implement the wire protocol, but I think
it should work.

R=teknico, bac
CC=
https://codereview.appspot.com/7741043

https://codereview.appspot.com/7741043/

« Back to merge proposal