Merge lp://staging/~gary/juju-gui/removeCharmworldV3Flag into lp://staging/juju-gui/experimental

Proposed by Gary Poster
Status: Merged
Merged at revision: 1180
Proposed branch: lp://staging/~gary/juju-gui/removeCharmworldV3Flag
Merge into: lp://staging/juju-gui/experimental
Diff against target: 1138 lines (+59/-578)
21 files modified
app/app.js (+3/-7)
app/store/charmworld.js (+0/-215)
app/subapps/browser/browser.js (+1/-1)
app/views/topology/bundle.js (+1/-1)
test/test_app.js (+1/-1)
test/test_browser_app.js (+11/-11)
test/test_browser_charm_details.js (+10/-10)
test/test_browser_editorial.js (+8/-8)
test/test_browser_search_view.js (+6/-6)
test/test_browser_search_widget.js (+1/-1)
test/test_bundle_details_view.js (+1/-1)
test/test_charmworld.js (+3/-298)
test/test_environment_view.js (+3/-3)
test/test_ghost_inspector.js (+1/-1)
test/test_inspector_charm.js (+2/-2)
test/test_inspector_constraints.js (+1/-1)
test/test_inspector_overview.js (+1/-1)
test/test_inspector_settings.js (+1/-1)
test/test_model.js (+1/-1)
test/test_service_module.js (+1/-1)
test/utils.js (+2/-7)
To merge this branch: bzr merge lp://staging/~gary/juju-gui/removeCharmworldV3Flag
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+193978@code.staging.launchpad.net

Description of the change

Remove charmworldv3 and APIv2

For QA, make sure that you can search for bundles (e.g., search for hatch) and make sure that the charm store seems to be working correctly.

https://codereview.appspot.com/22000043/

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+193978_code.launchpad.net,

Message:
Please take a look.

Description:
Remove charmworldv3 and APIv2

For QA, make sure that you can search for bundles (e.g., search for
hatch) and make sure that the charm store seems to be working correctly.

https://code.launchpad.net/~gary/juju-gui/removeCharmworldV3Flag/+merge/193978

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/22000043/

Affected files (+61, -578 lines):
   A [revision details]
   M app/app.js
   M app/store/charmworld.js
   M app/subapps/browser/browser.js
   M app/views/topology/bundle.js
   M test/test_app.js
   M test/test_browser_app.js
   M test/test_browser_charm_details.js
   M test/test_browser_editorial.js
   M test/test_browser_search_view.js
   M test/test_browser_search_widget.js
   M test/test_bundle_details_view.js
   M test/test_charmworld.js
   M test/test_environment_view.js
   M test/test_ghost_inspector.js
   M test/test_inspector_charm.js
   M test/test_inspector_constraints.js
   M test/test_inspector_overview.js
   M test/test_inspector_settings.js
   M test/test_model.js
   M test/test_service_module.js
   M test/utils.js

Revision history for this message
Richard Harding (rharding) wrote :

code looks good, checking qa

https://codereview.appspot.com/22000043/

Revision history for this message
Richard Harding (rharding) wrote :

LGTM qa-ok. Thanks for the update Here we goooooo!

https://codereview.appspot.com/22000043/

Revision history for this message
Brad Crittenden (bac) wrote :
Revision history for this message
Gary Poster (gary) wrote :

*** Submitted:

Remove charmworldv3 and APIv2

For QA, make sure that you can search for bundles (e.g., search for
hatch) and make sure that the charm store seems to be working correctly.

R=rharding, bac
CC=
https://codereview.appspot.com/22000043

https://codereview.appspot.com/22000043/

Revision history for this message
Gary Poster (gary) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches