lp://staging/~gary/juju-gui/removeCharmworldV3Flag
- Get this branch:
- bzr branch lp://staging/~gary/juju-gui/removeCharmworldV3Flag
Branch merges
- Juju GUI Hackers: Pending requested
-
Diff: 1138 lines (+59/-578)21 files modifiedapp/app.js (+3/-7)
app/store/charmworld.js (+0/-215)
app/subapps/browser/browser.js (+1/-1)
app/views/topology/bundle.js (+1/-1)
test/test_app.js (+1/-1)
test/test_browser_app.js (+11/-11)
test/test_browser_charm_details.js (+10/-10)
test/test_browser_editorial.js (+8/-8)
test/test_browser_search_view.js (+6/-6)
test/test_browser_search_widget.js (+1/-1)
test/test_bundle_details_view.js (+1/-1)
test/test_charmworld.js (+3/-298)
test/test_environment_view.js (+3/-3)
test/test_ghost_inspector.js (+1/-1)
test/test_inspector_charm.js (+2/-2)
test/test_inspector_constraints.js (+1/-1)
test/test_inspector_overview.js (+1/-1)
test/test_inspector_settings.js (+1/-1)
test/test_model.js (+1/-1)
test/test_service_module.js (+1/-1)
test/utils.js (+2/-7)
Branch information
Recent revisions
- 1179. By Gary Poster
-
Re-enable Landscape sim and fix inspector link
Changes to move units to service attributes broke the Landscape simulation because they were buggy, and we had no tests. Fixing that revealed that Landscape links were broken in the inspector if units appeared with Landscape problems while you observed the inspector. This branch also fixes that problem.
To QA, run the simulator on the sandbox and create 100 or 200 units in a service. Keep the inspector open after creation. You should see a few Landscape issues appear within a few seconds. If you open up the Landscape sections of the inspector, the link to Landscape at the bottom of the section should have a href that looks vaguely like it might point to Landscape, if Landscape were really hooked up.
R=rharding
CC=
https://codereview. appspot. com/21440044 - 1177. By Jeff Pihach
-
Fixes bundle vis for charms without versions
Some of Jorge's bundles didn't have versions specified
so they would not show up in the bundle visualizations
or allow them to be deployed. This fixes that limitation
and improves the error reporting when the user tries to
deploy two bundles with services that have the same names.R=gary.poster
CC=
https://codereview. appspot. com/21020043 - 1176. By Madison Scott-Clary
-
Autoposition services w/o annotations in bundles
If a bundle does not have service position annotations, generate a default layout and provide a textual warning for the user. As a drive-by, the centering code was fixed to properly center the topology.
To QA, check that the following URLs render decent-looking bundles:
* /sidebar/search/ bundle/ ~makyo/ openstack/ 2/openstack/ :flags: /charmworldv3/ ?text=makyo
* /sidebar/search/ bundle/ ~benji/ wiki/5/ wiki/:flags: /charmworldv3/ ?text=benji# bws-bundle
* /sidebar/search/ bundle/ ~hatch/ wiki/6/ envExport/ :flags: /charmworldv3/ ?text=hatch
* /sidebar/search/ bundle/ ~hatch/ wiki/7/ TestBundle/ :flags: /charmworldv3/ ?text=hatch R=jeff.pihach
CC=
https://codereview. appspot. com/20870043 - 1175. By Francesco Banconi
-
Honor the options type when exporting bundles.
Improve the way booleans, int and float
service options are exported in the bundle.Also fix a bug with boolean options and
checkboxes in the inspector:
- set an option to true and save;
- restore an option to false and save;
- the option label says "false" but
the checkbox is switched back to true.We might need to improve the way boolean options
are normalized before they are stored in the db.
They can be booleans or strings, I guess based
on the code path that executes the
service.set('config' ) call. Added an XXX comment. QA:
- try what described above in the inspector;
- set/unset/restore to default options,
including booleans, integers/floats and
strings; export the bundle; ensure it works.R=gary.poster
CC=
https://codereview. appspot. com/20370043 - 1173. By Jeff Pihach
-
Adds basket name to bundle token title
R=matthew.scott, gary.poster
CC=
https://codereview. appspot. com/20410043 - 1172. By Brad Crittenden
-
Fix name/email address parsing for commits.
R=rharding
CC=
https://codereview. appspot. com/20170044 - 1171. By Jeff Pihach
-
Improve the error reporting of bundle imports
R=gary.poster
CC=
https://codereview. appspot. com/17540044
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/juju-gui/experimental