Code review comment for lp://staging/~gary/juju-gui/ghostDeploy

Revision history for this message
Madison Scott-Clary (makyo) wrote :

LGTM, QA okay in Chrome/Go Env (starting up IE now, will comment if
anything goes wrong)

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js
File app/views/ghost-inspector.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/ghost-inspector.js#newcode306
app/views/ghost-inspector.js:306: ghostService.set('localCreation',
true);
On 2013/09/16 21:22:16, gary.poster wrote:
> This line is about...well, see the comment.

Would like to see this defined in the Service model's ATTRs with a
comment and default to false, just for consistency's sake.

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/13246050/diff/1/app/views/topology/service.js#newcode1099
app/views/topology/service.js:1099: // box.model.set('localCreation',
false);
Remove (assuming flag gets unset later?)

https://codereview.appspot.com/13246050/

« Back to merge proposal