Code review comment for lp://staging/~gary/juju-gui/exportBugs

Revision history for this message
Jeff Pihach (hatch) wrote :

Thanks for this fix!
LGTM QA OK!

https://codereview.appspot.com/15400052/diff/1/app/models/models.js
File app/models/models.js (right):

https://codereview.appspot.com/15400052/diff/1/app/models/models.js#newcode1193
app/models/models.js:1193: if (service.get('exposed')) {
Maybe we should change what the deployer expects or our service
attribute to match instead of doing this conversion.

https://codereview.appspot.com/15400052/diff/1/test/test_fakebackend.js
File test/test_fakebackend.js (right):

https://codereview.appspot.com/15400052/diff/1/test/test_fakebackend.js#newcode532
test/test_fakebackend.js:532: fakebackend = utils.makeFakeBackend();
How did this work before?

https://codereview.appspot.com/15400052/

« Back to merge proposal