Code review comment for lp://staging/~gary/juju-gui/doc-cleanup

Revision history for this message
Gary Poster (gary) wrote :

Thank you for the review!

I think your question is a great one about the SVG functions, but that's
for another day, another branch.

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js#newcode36
app/views/utils.js:36: @class utils
On 2013/05/23 22:35:28, jeff.pihach wrote:
> These comment blocks (all the way down) should probably be indented 2
spaces.

I didn't think the indent was required, but done.

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js#newcode181
app/views/utils.js:181: var removeSVGClass = function(selector,
class_name) {
On 2013/05/23 22:35:28, jeff.pihach wrote:
> Do the YUI versions of these functions not work?

> hasSVGClass
> addSVGClass
> removeSVGClass

I don't know. That's a question for a different clean up branch, I
think. (The main point of this branch is to test Aaron's new landing
command, actually. :-) )

https://codereview.appspot.com/9704043/

« Back to merge proposal