Code review comment for lp://staging/~gary/juju-gui/doc-cleanup

Revision history for this message
Jeff Pihach (hatch) wrote :

LGTM Thanks for the cleanup!

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js#newcode36
app/views/utils.js:36: @class utils
These comment blocks (all the way down) should probably be indented 2
spaces.

https://codereview.appspot.com/9704043/diff/1/app/views/utils.js#newcode181
app/views/utils.js:181: var removeSVGClass = function(selector,
class_name) {
Do the YUI versions of these functions not work?

hasSVGClass
addSVGClass
removeSVGClass

https://codereview.appspot.com/9704043/

« Back to merge proposal