Code review comment for lp://staging/~gary/juju-gui/databindingChangedValues

Revision history for this message
Gary Poster (gary) wrote :

Reviewers: mp+184407_code.launchpad.net,

Message:
Please take a look.

Description:
improve databinding changedValues accuracy

more accurately keep track of changed values
   switch changedValues to being an Object
   Make changedValues public
   added eq to databinding fields

This is a prerequisite to updating the inspector save UX.

https://code.launchpad.net/~gary/juju-gui/databindingChangedValues/+merge/184407

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/13608043/

Affected files (+267, -97 lines):
   A [revision details]
   M app/views/databinding.js
   M app/views/viewlet-manager.js
   M test/test_databinding.js
   M test/test_inspector_constraints.js

« Back to merge proposal